Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monorepo #371

Closed
wants to merge 10 commits into from
Closed

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jul 2, 2024

Ok. This is a big change.
Now optional dependencies are split into separate packages so that the heaps of interoperability code do not have to live inside galax main.
We can release the companion packages onto PyPI and keep them in lock-step with galax since they share the same VCS.
The packages now are:

`galax` <- `galax-interop-astropy`  <- `galax-suite`
        <-  `galax-interop-gala`    <—|

It's equivalent to galax[interop-all], but galax-suite suite exists to 1) collect all packages into one obvious suite 2) Easy testing.

Also this monorepo will eventually enable us to have separate testing badges for each library!

See https://github.com/manuel-koch/hatch-monorepo-sandbox for the layout.

@nstarman nstarman added this to the v0.1 milestone Jul 2, 2024
@nstarman
Copy link
Contributor Author

nstarman commented Jul 2, 2024

Diagnosing test failures:

  • CD is failing because galax-suite is building into src, which is triggering "W005: Wheel contains common toplevel name in library: src/". We kind of want it to build to src, but have it packaged into a different name. galax-suite then ends up being an implicit namespace package, which is very convenient.
  • tests are failing because they can't find a version of galax-interop-astropy. This is more pernicious. There's a released version of galax, but not of galax-interop-astropy. Since versioning depends on the git tag, I'm not sure how we get these tests passing in a branch!

@nstarman nstarman force-pushed the build-sep-package branch 3 times, most recently from 5332b95 to a827a9d Compare July 3, 2024 01:59
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
@adrn
Copy link
Collaborator

adrn commented Aug 24, 2024

Oof I don't know about this. Seems like a lot of effort to protect from installing a few additional dependencies...!

@nstarman
Copy link
Contributor Author

Yeah. it's not working at all ATM.

@nstarman nstarman closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants